Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Number of translated terminology entries on About page seems wrong #143

Open
skalee opened this issue Jul 5, 2020 · 5 comments
Open

Number of translated terminology entries on About page seems wrong #143

skalee opened this issue Jul 5, 2020 · 5 comments
Labels
question Further information is requested

Comments

@skalee
Copy link
Contributor

skalee commented Jul 5, 2020

About page says:

8704 translated terminology entries (full or partial) covering fourteen languages, which represents close to all of the participating countries in ISO/TC 211.

This is rendered from:

{{ site.data.metadata.term_count }} translated terminology entries (full or partial)
covering fourteen languages, which represents close to all of
the participating countries in ISO/TC 211.

The site.data.metadata.term_count is calculated by following script:

Dir['isotc211-glossary/concepts/*.yaml'].map do |yaml_file|
terms << YAML.load(IO.read(yaml_file))
puts "Processing #{yaml_file}"
end
term_count = terms.map do |t|
t.keys.length - 2
end.sum

Given the fact that each concept YAML consists of translation keys and two meta keys (namely term and termid), the term_count is the number of all localized concets, including English ones. Is it correct? I have doubts.

@skalee skalee added the question Further information is requested label Jul 5, 2020
@ronaldtse
Copy link
Member

Given the fact that each concept YAML consists of translation keys and two meta keys (namely term and termid), the term_count is the number of all localized concets, including English ones. Is it correct? I have doubts.

Yes that was my intention. Perhaps the description should say "8704 terminology entries" and "1xxx concepts"?

@skalee
Copy link
Contributor Author

skalee commented Jul 5, 2020

Or sth like:

  • 1302 English language terminology entries
  • 8704 terminology entries in all supported languages

Personally, I have no strong opinion on that. However, "translated terminology entries" is confusing to me. If original entries are in English, then in my understanding translated entries are in all languages except for English.

@ronaldtse
Copy link
Member

Okay let’s go with it.

@skalee
Copy link
Contributor Author

skalee commented Jul 8, 2020

On second thought, I'd rather leave it as it is:

The current contents in Geolexica are from the 5th release of the MLGT (20200602 edition), consisting of:

  • 1302 English language terminology entries (terms/definitions) from published ISO/TC 211 standards as of June 2020;
  • 8704 translated terminology entries (full or partial) covering fourteen languages, which represents close to all of the participating countries in ISO/TC 211.

Maybe it's a good idea to just delete "translated". I don't know. You speak English much better than me. Please change it or leave it, whatever you consider best.

@ronaldtse
Copy link
Member

@skalee can we close this? Thanks.

@ronaldtse ronaldtse moved this to 🆕 New in Geolexica Jul 24, 2022
@ronaldtse ronaldtse moved this from 🆕 New to 📋 Backlog in Geolexica Jul 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
question Further information is requested
Projects
Status: 📋 Backlog
Development

No branches or pull requests

2 participants