Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Metadata.yaml seems to be unnecessary #142

Open
skalee opened this issue Jul 5, 2020 · 3 comments
Open

Metadata.yaml seems to be unnecessary #142

skalee opened this issue Jul 5, 2020 · 3 comments

Comments

@skalee
Copy link
Contributor

skalee commented Jul 5, 2020

scripts/generate_metadata.rb produces YAML like this one:

concept_count: 1302
term_count: 8704
version: '20200602'

These are used on About page:

== Current content ({{ site.data.metadata.version }} edition)

The current contents in Geolexica are from the 5th release of the
MLGT ({{ site.data.metadata.version }} edition), consisting of:

* {{ site.data.metadata.concept_count }} English language terminology entries (terms/definitions)
from published ISO/TC 211 standards as of June 2020;

* {{ site.data.metadata.term_count }} translated terminology entries (full or partial)
covering fourteen languages, which represents close to all of
the participating countries in ISO/TC 211.

I see no reason for calculating concept_count nor term_count in a separate script. These two numbers should be calculated by Jekyll-Geolexica, similarly to how language statistics (displayed on Statistics page) are calculated: https://github.com/geolexica/geolexica-server/blob/35e2b9a1bc4f27e06634be8fc7430e28495512dc/lib/jekyll/geolexica/glossary.rb#L61-L70.

Glossary version cannot be calculated. It should be kept somewhere in geolexica/isotc211-glossary. Alternatively, it should be set in site config.

@ronaldtse
Copy link
Member

I see no reason for calculating concept_count nor term_count in a separate script. These two numbers should be calculated by Jekyll-Geolexica, similarly to how language statistics (displayed on Statistics page) are calculated: https://github.com/geolexica/geolexica-server/blob/35e2b9a1bc4f27e06634be8fc7430e28495512dc/lib/jekyll/geolexica/glossary.rb#L61-L70.

Correct, we can calculate these if possible.

Glossary version cannot be calculated. It should be kept somewhere in geolexica/isotc211-glossary. Alternatively, it should be set in site config.

Yes, we need to find a place to keep it. It should be kept in isotc211-glossary.

@skalee
Copy link
Contributor Author

skalee commented Jul 5, 2020

Okay, let's do it this way:

  • concept_count — total number of concepts, should be obtained from Jekyll-Geolexica
  • term_count — total number of localized concepts, should be obtained from Jekyll-Geolexica
  • version — cannot be obtained from Jekyll-Geolexica. Let's move it to glossary/version.yaml or integrate into glossary/tc211-termbase.meta.yaml. Is the glossary/tc211-termbase.meta.yaml good place for that? Will it break something? CC @strogonoff

@ronaldtse
Copy link
Member

version — cannot be obtained from Jekyll-Geolexica. Let's move it to glossary/version.yaml or integrate into glossary/tc211-termbase.meta.yaml. Is the glossary/tc211-termbase.meta.yaml good place for that? Will it break something?

Glossarist doesn't yet support editing tc211-termbase.meta.yaml , but it can be edited manually. Won't break anything, let's proceed. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants