Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clean up random data #36

Open
geoffrich opened this issue Aug 19, 2023 · 2 comments
Open

Clean up random data #36

geoffrich opened this issue Aug 19, 2023 · 2 comments

Comments

@geoffrich
Copy link
Owner

Some bad data started coming back from the Marvel API, e.g. trade paperbacks. Any comics that came back are now permanently in the set of random comic IDs. We should scrub the Redis DB and/or filter out comics so we don't show random comics not available on MU.

c7af095
@geoffrich
Copy link
Owner Author

Potential filter: title.includes('Trade Paperback')

@geoffrich
Copy link
Owner Author

Another way of doing this is to query the random data set when retrieving a year and remove items that are no longer present in the response. This could be done at a longer time interval depending on query cost.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@geoffrich