You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Due to some Marvel API change, non-MU comics (e.g. Conan) are being returning from the API. Trade paperbacks were also coming back (fixed with c7af095).
Comics are also being returned that aren't on MU yet, e.g. comics that were just released that will be on MU in a few months.
I think previously we were relying on hasDigitalIssue to only be set for MU comics, but this no longer seems to be the case. Queries with this set are not only returning non-MU comics that are available digitally, but also comics that aren't available digitally.
One thing I noticed is that for many of the affected comics, unlimitedDate and digitalPurchaseDate are identical, which shouldn't be true for many comics (verification TBD, not sure what this looks like for old comics added to MU that weren't previously available digitally).
Due to some Marvel API change, non-MU comics (e.g. Conan) are being returning from the API. Trade paperbacks were also coming back (fixed with c7af095).
Comics are also being returned that aren't on MU yet, e.g. comics that were just released that will be on MU in a few months.
I think previously we were relying on
hasDigitalIssue
to only be set for MU comics, but this no longer seems to be the case. Queries with this set are not only returning non-MU comics that are available digitally, but also comics that aren't available digitally.https://github.com/geoffrich/marvel-by-year/blob/c7af095ff5bd897cc95449654269bc1f989f6f40/src/lib/api.ts#L144
I'm not sure the best way to fix this.
One thing I noticed is that for many of the affected comics,
unlimitedDate
anddigitalPurchaseDate
are identical, which shouldn't be true for many comics (verification TBD, not sure what this looks like for old comics added to MU that weren't previously available digitally).Example responses
Savage Sword of Conan (not on MU)
Conan 1972 (not on MU)
Weapon H (on MU)
The text was updated successfully, but these errors were encountered: