Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More control on timestepping logic #3549

Closed
anne-glerum opened this issue Jun 22, 2020 · 1 comment
Closed

More control on timestepping logic #3549

anne-glerum opened this issue Jun 22, 2020 · 1 comment

Comments

@anne-glerum
Copy link
Contributor

As discussed in the biweekly ASPECT meeting, it would be great to have a plugin structure for timestepping control. An example would be @tjhei 's implementation to redo a timestep if the mesh resolution in the shear bands is not the same throughout the bands. Another application would be to assess the solution for a specific timestep size and recompute the timestep for a smaller timestep size if a certain threshold was exceeded.

@tjhei
Copy link
Member

tjhei commented Jun 22, 2020

Thanks for the reminder Anne.
I put things on hold to work on the release for now, but I should put my ideas down before I forget:

  • related is Nonlinear solver: deal with failure #2744 (redo timestep if nonlinear solver fails)
  • scenario: if a check determines that refinement is needed (run every time step?), refine and redo timestep
  • scenario: if the solution (for example stresses exceed threshold) redo using smaller time step

tjhei added a commit to tjhei/aspect that referenced this issue Aug 11, 2020
- introduce plugin architecture for time stepping
- move convection/conduction into their own plugins

part of geodynamics#3549
tjhei added a commit to tjhei/aspect that referenced this issue Aug 12, 2020
(note, currently sitting on top of geodynamics#3763)

- add a "function" plugin and a test for it
- fix a bug in the prm parsing of the timestepping class

Part 3 of N for geodynamics#3549
tjhei added a commit to tjhei/aspect that referenced this issue Aug 12, 2020
- introduce plugin architecture for time stepping
- move convection/conduction into their own plugins

part of geodynamics#3549
tjhei added a commit to tjhei/aspect that referenced this issue Aug 13, 2020
(note, currently sitting on top of geodynamics#3763)

- add a "function" plugin and a test for it

Part 3 of N for geodynamics#3549
tjhei added a commit to tjhei/aspect that referenced this issue Aug 13, 2020
(note, currently sitting on top of geodynamics#3763)

- add a "function" plugin and a test for it

Part 3 of N for geodynamics#3549
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants