Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor reaction system #88

Closed
11 of 13 tasks
srliao opened this issue Dec 5, 2021 · 4 comments
Closed
11 of 13 tasks

refactor reaction system #88

srliao opened this issue Dec 5, 2021 · 4 comments

Comments

@srliao
Copy link
Contributor

srliao commented Dec 5, 2021 •
edited
Loading

Refactor reaction system to properly implement freeze + chain freeze and update electrocharge code.

Also allow for non enemy targetables such as player and player spawn objects (guoba etc...)

  • overload
  • superconduct
  • melt
  • vaporize
  • electrocharged
  • swirl
  • crystallize
  • refactor target
  • update damage formula + remove reactionDamage
  • update onReaction hooks
  • shatter
  • target acquiring api (i.e. return list of target sorted by distance for specified x,y coord)
  • electrocharged aoe
@srliao
Copy link
Contributor Author

srliao commented Dec 6, 2021

need to fix #65 as well

@srliao
Copy link
Contributor Author

srliao commented Dec 8, 2021

also #83 should be improved by this

@srliao
Copy link
Contributor Author

srliao commented Dec 8, 2021

#60 to be fixed as well while fixing eula snapshot

@srliao srliao mentioned this issue Dec 22, 2021
Closed
@srliao
Copy link
Contributor Author

srliao commented Dec 31, 2021

this is mostly done in #105 , closing this in favour of #123 and #124

@srliao srliao closed this as completed Dec 31, 2021
theqp pushed a commit to theqp/gcsim that referenced this issue Aug 9, 2022
@srliao
update disclaimer (genshinsim#88)
22b337e
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@srliao