Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rework MIME Type handling #227

Open
jpfeuffer opened this issue Oct 17, 2018 · 4 comments
Open

Rework MIME Type handling #227

jpfeuffer opened this issue Oct 17, 2018 · 4 comments

Comments

@jpfeuffer
Copy link
Member

jpfeuffer commented Oct 17, 2018

There are some points to consider:

  1. Add an "any" or "*" MIME type, so some nodes can accept any type
  2. Maybe add missing mime types on the fly. (With a single extension of the newly found one, and a name like "unknown-$extension"
@jpfeuffer
Copy link
Member Author

Also
3) FileListPorts should probably have a MIMETypeSet to allow mixed lists.

@jpfeuffer
Copy link
Member Author

And what if mimetypes overlap, e.g. when multiple plugins include an extension in one of their mime types. Probably also not handled here.

@jpfeuffer
Copy link
Member Author

So I found the best possibility is just to use the extension as is, if no mimetype is found. Makes more sense than failing IMHO. A perfect match should always be allowed, only a fallback should be to compare possible Mimetype agreement.

@jpfeuffer
Copy link
Member Author

jpfeuffer commented Sep 2, 2024

Also, the CTDParser should be updated to read the "is_executable" tag for input files. Could help in putting some restrictions on the mine types even if no extension in the CTD is specified

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant