Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cancel jobs when a user is deleted #148

Open
abought opened this issue Mar 28, 2024 · 0 comments
Open

Cancel jobs when a user is deleted #148

abought opened this issue Mar 28, 2024 · 0 comments
Labels
enhancement New feature or request

Comments

@abought
Copy link
Collaborator

abought commented Mar 28, 2024

Summary

Currently, if a user deletes their account while a job is in the queue, it will continue running even though there may be no way to deliver results. (since they can't log in to get download links)

This is wasteful in times of peak load. We've recently started warning users with multiple accounts, and have seen some examples of people deleting accounts while jobs are running.

Proposed change

The user deletion code currently sets jobs to the user "public" but does not check if jobs are running.

It makes sense to keep some record of jobs for tracking purposes, but ideally, the jobs should be canceled if running (before being changed)

A much longer term solution would be to pair this with "soft deletion", where the user record in the DB was retained, with a new field is_deleted = true that blocks login etc. This would allow auditing of user behavior that is not possible when the entire row is completely removed from the DB.

@abought abought added the enhancement New feature or request label Mar 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant