Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 [BUG] - Faulty resolution of canonical URLs of level 3 ISiK FHIR resources #507

Open
holger-stenzhorn opened this issue Dec 27, 2024 · 0 comments
Labels
bug Something isn't working invalid This doesn't seem right

Comments

@holger-stenzhorn
Copy link

Description

For level 3 ISiK FHIR resources, their canonical URLs are resolved incorrectly because "latest" tag leads/redirects to the latest version of the level 4 and not to the latest version of level 3.

(To make it work again, you would simply have to change - as you do for level 2 - your "latest" redirection to (currently) "3.0.6", i.e. https://simplifier.net/resolve?canonical=https://gematik.de/fhir/isik/v3/Basismodul/StructureDefinition/ISiKPatient&[email protected])

("latest" would also work for levels 2 and 3 if their packages were stored in the respective levels' projects and named accordingly - as you do for level 1. However, there is certainly a good reason why you also store e.g. the basic module packages for levels 2 and 3 under the project “ISiK - Basic (Stufe 4)” and not under “ISiK - Basic (Stufe 2)” or “ISiK - Basic (Stufe 3)”).

Reproduction URL

https://gematik.de/fhir/isik/v3/Basismodul/StructureDefinition/ISiKPatient

Version or Branch

Only occurs with ISiK 3

Reproduction Steps

(To make it work again, you would simply have to change - as you do for level 2 - your Example for ISIKPatient:

❯ curl -sIL https://gematik.de/fhir/isik/v3/Basismodul/StructureDefinition/ISiKPatient | grep location
location: https://www.gematik.de/fhir/isik/v3/Basismodul/StructureDefinition/ISiKPatient
location: https://fhir.gematik.de/isik/v3/Basismodul/StructureDefinition/ISiKPatient
location: https://simplifier.net/resolve?canonical=https://gematik.de/fhir/isik/v3/Basismodul/StructureDefinition/ISiKPatient&scope=de.gematik.isik-basismodul@latest

❯ curl -s https://simplifier.net/resolve\?canonical\=https://gematik.de/fhir/isik/v3/Basismodul/StructureDefinition/ISiKPatient\&scope\=de.gematik.isik-basismodul@latest | grep ResolveUrl
        var ResolveUrl = "/resolve?canonical=https%3A%2F%2Fgematik.de%2Ffhir%2Fisik%2Fv3%2FBasismodul%2FStructureDefinition%2FISiKPatient\[email protected]";

Stack Trace and Logs

No response

Screenshots

No response

Software and Environment

No response

@holger-stenzhorn holger-stenzhorn added bug Something isn't working invalid This doesn't seem right labels Dec 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working invalid This doesn't seem right
Projects
None yet
Development

No branches or pull requests

1 participant