Modifications to show assurance cases in Eclipse Views #169
Conversation
tools/rack/pom.xml
Outdated
| <goals> | ||
| <goal>apply</goal> | ||
| </goals> | ||
| <goals></goals> |
There was a problem hiding this comment.
Wondering why this change was made. I assume this change falls back to the default goal (which may be the same as apply)?
There was a problem hiding this comment.
Oops - a local change snuck into the commit (this task does not work in my environment). Reverted.
| @@ -42,7 +42,8 @@ Require-Bundle: com.ge.research.jena, | |||
| org.eclipse.ui.forms, | |||
| org.slf4j.api, | |||
| org.yaml.snakeyaml, | |||
| org.eclipse.debug.ui | |||
| org.eclipse.debug.ui, | |||
| openjfx.swing;bundle-version="17.0.2" | |||
There was a problem hiding this comment.
I'm surprised this requirement doesn't cause any error. We are explicitly adding the javafx jars to this bundle's classpath instead of requiring Eclipse to find the javafx bundles in its P2 repositories. At best, this requirement is unnecessary; at worst, it may be muddling where the swing classes come from (are they coming from a bundle in P2 or a jar in the classpath?). We should remove this requirement since RITE still should work without it.
There was a problem hiding this comment.
Reverted the change. I suspect Eclipse inserted it.
| lib/javafx-swing.jar, | ||
| lib/javafx-swing-linux.jar, | ||
| lib/javafx-swing-mac.jar, | ||
| lib/javafx-swing-win.jar |
There was a problem hiding this comment.
Please keep all the jars sorted alphabetically. This helps maintainers check for missing jars which are in the lib directory but not on the bundle's classpath (note we do omit some jars from the lib directory on purpose, but still).
| lib/javafx-swing.jar,\ | ||
| lib/javafx-swing-linux.jar,\ | ||
| lib/javafx-swing-mac.jar,\ | ||
| lib/javafx-swing-win.jar |
There was a problem hiding this comment.
Likewise, please keep these filenames sorted alphabetically so maintainers can check for missing files more easily.
tools/rack/rack.plugin/pom.xml
Outdated
| @@ -42,115 +42,162 @@ | |||
| <dependency> | |||
| <groupId>org.openjfx</groupId> | |||
| <artifactId>javafx-base</artifactId> | |||
| <version>${version.javafx}</version> | |||
There was a problem hiding this comment.
All of these newly added versions are redundant because the parent pom already has the complete information (including versions) in its dependencyManagement section. This allows the child pom to "inherit" the version from the parent pom.
Testing Reviews (on Windows)
|
Updated with a merge from main and pushed changes to the PR |
|
Need to test on windows before merging |
Fixes Issue #139