Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inconsistent use of Type Hints #2

Open
teward opened this issue Dec 10, 2019 · 4 comments
Open

Inconsistent use of Type Hints #2

teward opened this issue Dec 10, 2019 · 4 comments
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@teward
Copy link

teward commented Dec 10, 2019

I noticed that there is an inconsistent use of Type Hits within this program.

Some modules and functions have type hints in place, others do not.

Specifically, the run command doesn't have type hints, while many of the other commands do.

def run(cwd=os.getcwd(), strict=True, verbose=False, **kwargs):

Have you considered adding type hints?

@gchamon
Copy link
Owner

gchamon commented Dec 11, 2019

I should have typed the run return value to being subprocess.Process, if my memory serves me right. I could try typing the arguments, but I think it will be challenging for **kwargs

@teward
Copy link
Author

teward commented Dec 11, 2019

**kwargs can be one of the expected types, or Union[type1, type2, ...] if we go deep with the typing library. Just a thought ;)

@gchamon
Copy link
Owner

gchamon commented Dec 11, 2019

thanks =D and thanks for the interest in the project. I will revise the typing in the project as soon as possible

@gchamon gchamon added enhancement New feature or request good first issue Good for newcomers labels Mar 4, 2020
@gchamon
Copy link
Owner

gchamon commented May 8, 2021

better late than never. On it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

2 participants