Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handled NotFoundException to fix IPT fails #609

Merged
merged 1 commit into from
Aug 20, 2024
Merged

Handled NotFoundException to fix IPT fails #609

merged 1 commit into from
Aug 20, 2024

Conversation

ahakanzn
Copy link
Contributor

(#596)

@mike-podolskiy90
Copy link
Contributor

mike-podolskiy90 commented Aug 13, 2024 •
edited
Loading

You need to make sure it works consistently for both controller and client. I suspect it might return null in some cases and throw NFE in other.

Also, there are two more places in this class where installationService.get and organizationService.get are called (See isValidOnUpdate and isValid)

@ahakanzn ahakanzn force-pushed the 596-resourse-registration-error-for-ipt branch from 91f70c3 to 4c57520 Compare August 14, 2024 10:48
@mike-podolskiy90 mike-podolskiy90 linked an issue Aug 14, 2024 that may be closed by this pull request
Resource registration fails in IPT because of unknown registry error #596
Open
@mike-podolskiy90 mike-podolskiy90 merged commit d61deea into dev_jdk8 Aug 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mike-podolskiy90 mike-podolskiy90 Awaiting requested review from mike-podolskiy90

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Resource registration fails in IPT because of unknown registry error
2 participants
@ahakanzn @mike-podolskiy90