Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

RGBDS is dirty :D #64

Open
SelvinPL opened this issue Feb 3, 2025 · 4 comments · May be fixed by #67
Open

RGBDS is dirty :D #64

SelvinPL opened this issue Feb 3, 2025 · 4 comments · May be fixed by #67
Labels
bug Something isn't working

Comments

@SelvinPL
Copy link
Contributor

SelvinPL commented Feb 3, 2025 •
edited
Loading

When we build rgbd after patching version shown with --version becomes vX.X.X-dirty

it is because --dirty flag passed to git in build script

We could try to patch it out as without this flag version will no longer be dirty

Image

Edit: or here?
@Rangi42 Rangi42 added the bug Something isn't working label Feb 3, 2025
@SelvinPL
Copy link
Contributor Author

SelvinPL commented Feb 3, 2025 •
edited
Loading

Or we could incorporate this little change (adding symbol for every CPU instruction with some flag) to rgbs source code and no longer need patching rgbds source for rgbds-live build 👹

@SelvinPL SelvinPL linked a pull request Feb 4, 2025 that will close this issue
Open
@SelvinPL
Copy link
Contributor Author

SelvinPL commented Feb 4, 2025

https://selvin.pl/rgbds-live-test/?asm=--version

Image

@avivace
Copy link
Member

avivace commented Feb 4, 2025

Is there a particular reason why we don't want "dirty" to be part of the version code? I would argue it's actually useful to know that we're not running a vanilla version of RGBDS but in fact it's patched...

@SelvinPL
Copy link
Contributor Author

SelvinPL commented Feb 4, 2025

But this patch is only for debuging purpose. It just adds unique symbol for every CPU instruction.

Also I did it becuase Sylvie's comment here

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

remove dirty flags from build for proper version SelvinPL/rgbds-live
3 participants
@SelvinPL @avivace @Rangi42