Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The template_workspace.yaml to setup the workspace is referencing the wrong branch #28

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

cord-burmeister
Copy link
Contributor

🦟 Bug fix

Fixes #27

Summary

Changed the branch name

Checklist

  • [ X] Signed all commits for DCO
  • Added tests
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • Consider updating Python bindings (if the library has them)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

@cord-burmeister
Copy link
Contributor Author

cord-burmeister commented May 19, 2024

I must confess, that i am not sure to correct the situation in the repository properly.
I am a beginner concerning ROS and might not understand the background.

I was using the modifications to run the changes in my project. Now i see the following
error when updating the repositories from a clean workspace with humble and harmonic on Ubuntu 22.04.

cd ~/template_ws/src
vcs import < template_workspace.yaml
cd ~/template_ws
rosdep update
rosdep install --from-path src --ignore-src -r -i -y --rosdistro humble

I get the error messages

ERROR: the following packages/stacks could not have their rosdep keys resolved
to system dependencies:
ros_gz_image: Cannot locate rosdep definition for [gz-transport13]
ros_gz_bridge: Cannot locate rosdep definition for [gz-transport13]
sdformat_urdf: Cannot locate rosdep definition for [sdformat14]
ros_gz_sim: Cannot locate rosdep definition for [gz-transport13]
Continuing to install resolvable dependencies...
#All required rosdeps installed successfully

I think this comes from the package.xml in the updated sdformat_urdf package from the humble branch.

  <!-- Fortress (default) -->
  <depend condition="$ROS_DISTRO == 'humble'">sdformat12</depend>
  <!-- Garden -->
  <depend condition="$GZ_VERSION == garden">sdformat13</depend>
  <!-- Harmonic -->
  <depend condition="$GZ_VERSION == harmonic">sdformat14</depend>

I set the GZ_VERSION as described.

I try to find the package sdformat14 under
https://index.ros.org/p/sdformat_urdf/github-ros-sdformat_urdf/#humble

No luck.

I just do not understand how it should work and i am not sure if my contribution is of any help.

PS: I found out that after reinstalling gazebo harmonic, every thing works

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The template_workspace.yaml to setup the workspace is referencing the wrong branch
2 participants