Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Addition of a private member to store data #15

Open
sauk2 opened this issue Dec 2, 2023 · 0 comments · May be fixed by #19
Open

Addition of a private member to store data #15

sauk2 opened this issue Dec 2, 2023 · 0 comments · May be fixed by #19
Labels
enhancement New feature or request

Comments

@sauk2
Copy link

sauk2 commented Dec 2, 2023

Desired behavior

Currently, the BasicSystem and FullSystem plugins do not have a private member to store data either extracted from the SDF or created internally during plugin operation.

Implementation suggestion

  • Forward declare a class and create a unique pointer to the same in the header
  • Define an implementation of the class in the cpp
  • Add lines in Configure to get values from the SDF and assign them to the private member
  • To show functionality, add parameter tags in the XML of the plugin in the world SDF

PS. If this is a valid request and no one has started working on this, I have an implementation in my fork for which I can generate a PR.

@sauk2 sauk2 added the enhancement New feature or request label Dec 2, 2023
@quarkytale quarkytale linked a pull request Apr 22, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant