Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use ign-math SemanticVersion in LocalCache.cc #51

Open
osrf-migration opened this issue Jan 25, 2019 · 3 comments
Open

Use ign-math SemanticVersion in LocalCache.cc #51

osrf-migration opened this issue Jan 25, 2019 · 3 comments
Labels
enhancement New feature or request

Comments

@osrf-migration
Copy link

Original report (archived issue) by Nate Koenig (Bitbucket: Nathan Koenig).


Summary

We can use SemanticVersioning here: https://osrf-migration.github.io/ignition-gh-pages/#!/ignitionrobotics/ign-fuel-tools/pull-requests/82/ready-integration-with-ign-gazebo/activity#comment-89119795

Motivation

The SemanticVersion class contains logic for properly comparing version numbers. This will add a dependency on ign-math.

@osrf-migration
Copy link
Author

Original comment by Louise Poubel (Bitbucket: chapulina, GitHub: chapulina).


Note that we already have an indirect dependency on libignition-math6 through libignition-common3, and for some reason pipelines is explicitly installing libignition-math4-dev

@osrf-migration
Copy link
Author

Original comment by Steve Peters (Bitbucket: Steven Peters, GitHub: scpeters).


that sounds like a bug in the pipeline. I would change the math4 to math6

@osrf-migration
Copy link
Author

Original comment by Steve Peters (Bitbucket: Steven Peters, GitHub: scpeters).


I don't think it's a big problem to add an explicit dependency on ignition-math since it's already being used implicitly anyway

@osrf-migration osrf-migration added minor enhancement New feature or request labels Apr 15, 2020
@chapulina chapulina removed the minor label May 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants