Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inconsistent resource naming #15

Open
rfranzke opened this issue Mar 14, 2020 · 6 comments
Open

Inconsistent resource naming #15

rfranzke opened this issue Mar 14, 2020 · 6 comments
Labels
kind/enhancement Enhancement, improvement, extension lifecycle/rotten Nobody worked on this for 12 months (final aging stage)

Comments

@rfranzke
Copy link
Member

What would you like to be added:
In a shoot, the rolebindings have inconsistent names:

$ ks get rolebinding
NAME                                                                AGE
...
garden.sapcloud.io:psp:calico                                       24h
garden.sapcloud.io:psp:calico-kube-controllers                      24h
garden.sapcloud.io:psp:calico-typha                                 24h
...
gardener.cloud:psp:typha-cpa                                        24h
gardener.cloud:psp:typha-cpva                                       24h
...
typha-cpha                                                          24h

It probably makes sense to also check the other resources.

Why is this needed:
Consistency

@rfranzke rfranzke added the kind/enhancement Enhancement, improvement, extension label Mar 14, 2020
@ialidzhikov
Copy link
Member

ialidzhikov commented Mar 14, 2020

The garden.sapcloud.io: prefixed ones are already switched to gardener.cloud with #7.

@rfranzke
Copy link
Member Author

Hm, probably the old names are not cleaned up for existing shoots? See above, this was a new cluster created 24h ago - why do the rolebindings have the same creation timestamps?

@ialidzhikov
Copy link
Member

Probably your extension version is v1.3.0? The referenced change above is still not released.

@rfranzke
Copy link
Member Author

Ah okay, understood. Thank you! So, the only "open inconsistency" is

$ ks get rolebinding
NAME                                                                AGE
...
gardener.cloud:psp:typha-cpa                                        24h
gardener.cloud:psp:typha-cpva                                       24h
...
typha-cpha     

?

@ialidzhikov
Copy link
Member

This typha-cpha RoleBinding is not for PSP, but generally I agree that we could prefix it with gardener.cloud for consistency. There might be also others.

@rfranzke
Copy link
Member Author

Yes, probably it should even be prefixed with networking.gardener.cloud:calico:... or something similar.

@ghost ghost added the lifecycle/stale Nobody worked on this for 6 months (will further age) label May 14, 2020
@rfranzke rfranzke removed the lifecycle/stale Nobody worked on this for 6 months (will further age) label Jun 22, 2020
@gardener-robot gardener-robot added the lifecycle/stale Nobody worked on this for 6 months (will further age) label Sep 19, 2020
@gardener-robot gardener-robot added lifecycle/rotten Nobody worked on this for 12 months (final aging stage) and removed lifecycle/stale Nobody worked on this for 6 months (will further age) labels Nov 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/enhancement Enhancement, improvement, extension lifecycle/rotten Nobody worked on this for 12 months (final aging stage)
Projects
None yet
Development

No branches or pull requests

3 participants