Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

open() call in setup.py does not work on Windows #20

Open
anjos opened this issue Oct 17, 2024 · 0 comments
Open

open() call in setup.py does not work on Windows #20

anjos opened this issue Oct 17, 2024 · 0 comments

Comments

@anjos
Copy link

anjos commented Oct 17, 2024

The fact that setup.py directly opens the README.md to read does not really work under windows, since the default encoding is not UTF-8 (by default it is CP1252), and that file contains emojis (c.f. conda-forge/staged-recipes#27901).

Would it be possible to port this package to use a more modern version of project setup (e.g. via pyproject.toml). In this case, one wouldn't have to use open at all. You can port your setup.py using hatch for example.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant