Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Define and check position angles #135

Open
3 tasks
cdeil opened this issue Jul 18, 2017 · 0 comments
Open
3 tasks

Define and check position angles #135

cdeil opened this issue Jul 18, 2017 · 0 comments

Comments

@cdeil
Copy link
Contributor

cdeil commented Jul 18, 2017

At the moment we have a pa key for spatial model position angle in our schema:

and we have ~ 20 files where this info was added:
https://github.com/gammapy/gamma-cat/search?p=3&q=%27pa%3A%27&type=&utf8=%E2%9C%93

Currently position angles aren't well-defined, they all need a frame (radec or galactic), and they need to be uniform in their definition (e.g. "east or north" or something like that).
The tasks here are to:

  • Change the schema to support data entry with multiple frames and orientations so that data entry can be done as it is in the paper, without thinking and room for error. Presumably add an "orientation" string field.
  • Change the scripts to process that new "orientation" parameter and convert to a new uniform orientation.
  • Check the data entry for all ~ 20 sources we have already against the paper, to make sure it's correct. (in many cases a helpful comment concerning orientation from the paper was already left in the YAML file).

Until someone implements this, people doing data entry should always leave a one-line comment above the pa: line, stating the orientation as mentioned in the paper.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant