Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix destinations and plugins in docs #19444

Open
bernt-matthias opened this issue Jan 22, 2025 · 1 comment
Open

Fix destinations and plugins in docs #19444

bernt-matthias opened this issue Jan 22, 2025 · 1 comment

Comments

@bernt-matthias
Copy link
Contributor

bernt-matthias commented Jan 22, 2025

Describe the bug

In #7854 (comment) destinations have been renamed to environments (and plugins to runners). Unfortunately this change has not been done in the docs and admins. This seems cause problems for users (ie. admins).

From the PR:

Fix up some terminology (at least from a user facing standpoint) that @natefoo and I have wanted to cleanup for a while. In particular they are runners not plugins now (since everything is a plugin) and they are environments not destinations (since destination sounds like a physical location, when really you are defining a lot of context besides where the job runs - you define how it runs also and how it is configured - so environment feels more appropriate).

The motivation is fine (and we definitely should not change it back), but it would have been much better (IMO) to simply define (and document) the terminology instead of relying on the intuitive meaning of a single word (which never can grasp such a complex concept .. in particular not for everyone).

@bernt-matthias bernt-matthias changed the title Fix destinations and plugins in docs Fix destinations and plugins in docs Jan 22, 2025
@bernt-matthias
Copy link
Contributor Author

and we definitely should not change it back

Hmm not sure anymore.

At least training material uses the term environment.

In summary it might be a good idea to revert to "destination" in https://github.com/galaxyproject/galaxy/blob/dev/lib/galaxy/jobs/__init__.py and to properly define the term in the docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant