Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

History Storage Location Incorrectly Cached When Creating New History #19412

Closed
jmchilton opened this issue Jan 16, 2025 · 2 comments · Fixed by #19491
Closed

History Storage Location Incorrectly Cached When Creating New History #19412

jmchilton opened this issue Jan 16, 2025 · 2 comments · Fixed by #19491

Comments

@jmchilton
Copy link
Member

Minimal Example on usegalaxy.org

  • Create a new history.
Image
  • Change the storage location.
Image
  • Create a second new history.
  • Show the storage location popover. It has the cached older histories default.
Image

A hard refresh renders the correct default for this second new history, so I'm fairly sure this is just some sort of caching problem.

@ElectronicBlueberry
Copy link
Member

ElectronicBlueberry commented Jan 20, 2025

This seems like a reactivity issue. This line decouples the reactivity from the history: https://github.com/galaxyproject/galaxy/blob/dev/client/src/components/History/CurrentHistory/HistoryCounter.vue#L57

This can be fixed with a watcher, or removing the ref and solely relying on the history object as a source of truth, and updating that.

I cannot confirm or test this at the moment, as I do not have object stores set up locally.

@martenson
Copy link
Member

seems like a duplicate of #16826 -- but with better description

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants