-
-
Notifications
You must be signed in to change notification settings - Fork 149
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Feature]: Support for Google AdSense #315
Comments
In the home page, it would be fine to put advertisements just like posts... in posts page, indeed, it would be great to put advertisements on both sides |
OK, but I am still concerned about whether it is a good idea to put ads on the home page. And sure, we can also put ads on both sides of the post pages. |
I think it's better this way: offer both ways and then let the user choose which one to turn on or off. |
I've already added a slot for AdSense on the post page. To place your AdSense script, you can create an For the home page, I've not had permission to open my AdSense, so I still try to find a way to test it. |
Now it moves above the TOC. |
Feature request
The theme already has support for Google Analytics. I think It would be nice to also have easy integration for Google AdSense on websites in production.
Proposed solution
I think we could easily add a simple partial loading the script in
baseof.html
pulling required ids and params from the config like already happens with Google Analytics.Additional context
I also think this feature should be opt-in and disabled by default. Nobody wants to promote ads spamming on websites😜.
Nevertheless I think it might be a useful feature for consumers of the theme and have its close to ethical purposes.
The text was updated successfully, but these errors were encountered: