Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Completion of error handling #896

Closed
elfring opened this issue Sep 2, 2023 · 5 comments
Closed

Completion of error handling #896

elfring opened this issue Sep 2, 2023 · 5 comments
Labels
skip:changelog Issue/PR should skip CHANGELOG type:bug Something's broken!

Comments

@elfring
Copy link

elfring commented Sep 2, 2023

Would you like to add more error handling for return values from functions like the following?

@elfring elfring added the type:bug Something's broken! label Sep 2, 2023
@ThomasAdam
Copy link
Member

Hi @elfring

Very few codebases which I have seen seem to care about checking for fclose()'s return value -- so I think we can skip that.

As for malloc, we should be using fxmalloc() instead, so if you wanted to send a patch through for that, I'd appreciate it.

@elfring
Copy link
Author

elfring commented Sep 2, 2023

@ThomasAdam
Copy link
Member

I'm not sure I understand what you're asking with your second point -- this project doesn't use aspect-oriented software design.

@elfring
Copy link
Author

elfring commented Sep 2, 2023

💭 I suggest to avoid ignorance of return values a bit more.
Would you like to detect every error situation as early as possible?


🔮 Will interests grow for the application of higher level development tools?

@ThomasAdam
Copy link
Member

Submit a pull request please with your suggestions for fclose and any other functions you feel are missing return value checks.

@ThomasAdam ThomasAdam added the skip:changelog Issue/PR should skip CHANGELOG label Sep 3, 2023
@ThomasAdam ThomasAdam closed this as not planned Won't fix, can't repro, duplicate, stale Sep 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
skip:changelog Issue/PR should skip CHANGELOG type:bug Something's broken!
Projects
None yet
Development

No branches or pull requests

2 participants