Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

reserved identifier violation #104

Closed
elfring opened this issue May 27, 2020 · 2 comments
Closed

reserved identifier violation #104

elfring opened this issue May 27, 2020 · 2 comments
Labels
area:build Relates to compiling/buildsystem of fvwm difficulty:gfi Issue is suitable for a first-time contributor/developer help wanted Development help required (see `difficulty:*`) skip:changelog Issue/PR should skip CHANGELOG
Milestone
post-1.0

Comments

@elfring
Copy link

elfring commented May 27, 2020

I would like to point out that identifiers like “_EWMH_” and “_MENUS_” do not fit to the expected naming convention of the C language standard.
Would you like to adjust your selection for unique names?
@ThomasAdam
Copy link
Member

Hi @elfring,

Indeed, you're correct. This is from circa 2001.

As always, patches welcome. Bonus points from your kind self, if you use coccinelle to do it.

Always happy to be increasing the cocci scripts in contrib/coccinelle...

Thanks,
Thomas

@ThomasAdam ThomasAdam added this to the 1.0 milestone May 27, 2020
@ThomasAdam ThomasAdam modified the milestones: 1.0, post-1.0 Jun 3, 2020
@ThomasAdam ThomasAdam added difficulty:gfi Issue is suitable for a first-time contributor/developer help wanted Development help required (see `difficulty:*`) area:build Relates to compiling/buildsystem of fvwm and removed development labels Dec 20, 2020
@ThomasAdam ThomasAdam added the skip:changelog Issue/PR should skip CHANGELOG label Aug 30, 2023
@ThomasAdam ThomasAdam closed this as not planned Won't fix, can't repro, duplicate, stale Aug 30, 2023
@elfring
Copy link
Author

elfring commented Aug 31, 2023

💭 How do you think about to avoid that this software depends on undefined behaviour?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area:build Relates to compiling/buildsystem of fvwm difficulty:gfi Issue is suitable for a first-time contributor/developer help wanted Development help required (see `difficulty:*`) skip:changelog Issue/PR should skip CHANGELOG
Projects
FVWM3
Status: Done
Milestone
post-1.0
Development

No branches or pull requests
2 participants
@ThomasAdam @elfring