Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NPM not updated with create-react-class update #163

Open
rstumbaugh opened this issue Jul 2, 2017 · 10 comments
Open

NPM not updated with create-react-class update #163

rstumbaugh opened this issue Jul 2, 2017 · 10 comments

Comments

@rstumbaugh
Copy link

rstumbaugh commented Jul 2, 2017

NPM package still using React.createClass, resulting in the same errors as before. Build scripts also give an error when I try to manually install.

@rstumbaugh rstumbaugh changed the title NPM not updated with create-react-class update, and current build scripts not working for manual install NPM install fails Jul 3, 2017
@rstumbaugh rstumbaugh changed the title NPM install fails NPM not updated with create-react-class update Jul 3, 2017
@KatSick
Copy link

KatSick commented Jul 27, 2017

+1. React 16 is now in beta, and with these warning i can't switch to it. Can I open PR or something to help ?

@rstumbaugh
Copy link
Author

@KatSick I just ended up switching to react-select unfortunately. Looks like that is being updated fairly often.

@elisherer
Copy link
Contributor

@KatSick, Already did it on my PR #160.

@furqanZafar
Copy link
Owner

Try version 3.0.0 it's react 16 compatible thanks @elisherer

@jameswyse
Copy link

@furqanZafar thanks for the update. I just tried upgrading to 3.0.0 but am getting errors about react-dom-factories being missing (I added it as a regular dependency to my project but still get errors)

./node_modules/react-selectize/src/DivWrapper.js
Module not found: Error: Can't resolve 'react-dom-factories' in 'node_modules/react-selectize/src'

@furqanZafar
Copy link
Owner

i added it as a peer dep

@furqanZafar
Copy link
Owner

I published a new version 3.0.1, to lock react-transition-group peer dependency to version 1.1.2 for now (the latest version has many breaking changes), your package.json must look like this

{
    "dependencies": {
        "react": "^16.0.0-beta.2",
        "react-addons-css-transition-group": "^15.6.0",
        "react-addons-shallow-compare": "^15.6.0",
        "react-dom": "^16.0.0-beta.2",
        "react-dom-factories": "^1.0.0",
        "react-selectize": "^3.0.1",
        "react-transition-group": "^1.1.2"
    }
}

@jameswyse
Copy link

thanks, that worked! 👍

@vkrol
Copy link

vkrol commented Jul 29, 2017

@furqanZafar I think that we don't need react-addons-css-transition-group and react-addons-shallow-compare in dependencies anymore?

@joshi-chinmay
Copy link

@vkrol Hey, I had the same issue. But looks like we need react-addons-css-transition-group and react-addons-shallow-compare.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

7 participants