Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Split parts #19

Open
SaFrMo opened this issue Nov 9, 2017 · 1 comment
Open

Split parts #19

SaFrMo opened this issue Nov 9, 2017 · 1 comment

Comments

@SaFrMo
Copy link
Contributor

SaFrMo commented Nov 9, 2017

This plugin seems like it should be split into two parts:

  1. A WP/Shopify auto-sync tool, and
  2. A set of Vue components.

The WP end of things can be the auto-sync tool, while the Vue components can be split into a separate NPM package. Thoughts @jrobson153 ?

@johndigital
Copy link
Contributor

I agree 100%

It would also be great to tie it in with Rest-Easy, maybe wp-shopify can register a bunch of rest-easy filters adding product data into the serializers for wshop-products. Recently while using this with Vuepress I was having a hard time keeping all product info together since half of it would come in from Shopify asynchronously and the other half was already resteasy-ed onto the page.

Curious how we make an npm module of components work in a useful way though. Right now it's built in that strange way of referencing the $root all the time, not sure how to translate those into something to be used with a Vuepress site. Any ideas?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants