Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some potential improvements #23

Open
fruitfly1026 opened this issue Sep 21, 2020 · 3 comments
Open

Some potential improvements #23

fruitfly1026 opened this issue Sep 21, 2020 · 3 comments
Assignees

Comments

@fruitfly1026
Copy link

  • Generate the mappings in the same location with the output tensor file.
  • Remove specifying the output tensor file for query.
@fruitfly1026
Copy link
Author

@ShadenSmith I'm trying to this in another branch, then do the merge request to you~

@ShadenSmith
Copy link
Contributor

Awesome! Thanks @fruitfly1026 !

@fruitfly1026
Copy link
Author

@ShadenSmith NP~ :-P

  • One more: I found the date types only support extracting member values. E.g., extracting day by lambda x: date_parser.parse(x).day. But we cannot convert to a cumulative day value by including year and month info, right? If so, I can also work on this.

@fruitfly1026 fruitfly1026 self-assigned this Sep 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants