Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix PR349 #370

Open
2 tasks
KjellMorgenstern opened this issue Mar 30, 2023 · 1 comment
Open
2 tasks

Fix PR349 #370

KjellMorgenstern opened this issue Mar 30, 2023 · 1 comment

Comments

@KjellMorgenstern
Copy link
Member

KjellMorgenstern commented Mar 30, 2023

  • In PR349 the layer for the breadboard view should have been "breadboardbreadboard" instead.

  • ensure gerber export works

  • stroke-width has been applied to groups, which does not work with Fritzing 0.9.10. Check with Fritzing 1.0.0 development that this now indeed works, and post a screenshot here (or fix it)

  • circles instead of ellipses might be needed. It does not seem to be a problem though.

#349

@vanepp
Copy link
Contributor

vanepp commented Mar 30, 2023

circles instead of ellipses might be needed. It does not seem to be a problem though.

That is a problem in the pcb svg, but doesn't appear to be present in mine (the pads are all circles and FritzingCheckPart.py checks for that.) Ellipses in the pcb svg will not generate holes in the gerber output (while showing fine in Fritzing!)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants