Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Meshviewer About Screen does not adjust legend colors #7

Open
maurerle opened this issue Dec 19, 2022 · 2 comments
Open

Meshviewer About Screen does not adjust legend colors #7

maurerle opened this issue Dec 19, 2022 · 2 comments

Comments

@maurerle
Copy link
Member

When a custom color for new, online, offline or lost is set on the map, the legend in the about config stays with the default colors.

Expected Behavior

The about dialog should show the correct used colors defined in the config.
I think, that this is also an upstream issue.

Current Behavior

Changing the node color does not change the legend color in the legend-online scss class in about.js:

https://github.com/freifunk-ffm/meshviewer/blob/10ab1ead2c1c0e57674dc1d81be4bfccdcbc6877/lib/about.js#L10

Possible Solution

Steps to Reproduce

Context

Your Environment

  • Version used:
  • Browser Name and version:
  • Operating System and version (desktop or mobile):
  • Link to your project:

Screenshots

image

@genofire
Copy link

Whats your additional scss?

@maurerle
Copy link
Member Author

maurerle commented Dec 20, 2022

I did not change anything at the scss

I just added:

  "icon":{
    "base":{
      "fillOpacity":0.8,
      "opacity":0.8,
      "weight":2,
      "radius":6,
      "className":"stroke-first"
    },
    "online":{
      "fillOpacity":1,
      "opacity":1,
      "color":"#1566A9",
      "fillColor":"#5DA439"
    },
    "offline":{
      "color":"#D43E2A",
      "fillColor":"#D43E2A",
      "radius":3
    },
    "lost":{
      "color":"#D43E2A",
      "fillColor":"#D43E2A",
      "radius":4
    },
    "alert":{
      "color":"#D43E2A",
      "fillColor":"#D43E2A",
      "radius":5
    },
    "new":{
      "fillOpacity":1,
      "opacity":0.5,
      "color":"#1566A9",
      "fillColor":"#93E929"
    }
  },

to the config

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants