Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Factored prior over multivariate distributions #31

Open
zsteve opened this issue Nov 10, 2021 · 1 comment
Open

Factored prior over multivariate distributions #31

zsteve opened this issue Nov 10, 2021 · 1 comment

Comments

@zsteve
Copy link

zsteve commented Nov 10, 2021

Thanks for this package! At the moment, the Factored distribution only applies to UnivariateDistributions. Is there any reason currently the code does not support MultivariateDistribution?

The reason I am interested here is that I would like to estimate transition matrices using ABC. In this setting, the appropriate choice of prior would be a Dirichlet distribution for each row of the transition matrix. Then the prior over transition matrices should be something like

Factored([Dirichlet(zeros(N)) for _ in eachrow(P)]).

As a hack, I've just extended the Factored type to allow MultivariateDistribution. This seems to work as-is. Would be curious to see whether this is something that can be incorporated into the package. https://github.com/zsteve/KissABC.jl/tree/multivariatefactor

@francescoalemanno
Copy link
Owner

francescoalemanno commented Nov 23, 2021

Hi steve, open up a PR and add a few tests for the various sampling strategies :)
I will be very glad to take a look at your improvements

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants