Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

debt: use the single Etherscan V2 API endpoint for unified verification / query flow w/ single API key #9196

Open
zerosnacks opened this issue Oct 25, 2024 · 2 comments
Labels
A-internals Area: internals A-verification Area: verification T-debt Type: code debt T-feature Type: feature T-post-V1 Area: to tackle after V1

Comments

@zerosnacks
Copy link
Member

zerosnacks commented Oct 25, 2024

Component

Other (please describe)

Describe the feature you would like

We currently have a lot of code in place to handle multichain Etherscan verification due to the different endpoints and API keys associated with each.

With the release of Etherscan V2 there is now a single unified API endpoint: https://docs.etherscan.io/etherscan-v2 accessible with a single API key

Additional context

It is currently still in beta but worth exploring

Part of this ticket would be to double check if there are no breaking changes in the V2 API

Note: it requires passing a ?chainid=n as a parameter where n is the chain id: https://docs.etherscan.io/etherscan-v2/getting-started/v2-quickstart#if-youre-coming-from-v1

@zerosnacks zerosnacks added T-feature Type: feature T-debt Type: code debt A-verification Area: verification A-internals Area: internals labels Oct 25, 2024
@github-project-automation github-project-automation bot moved this to Todo in Foundry Oct 25, 2024
@zerosnacks zerosnacks changed the title feat: update Etherscan API endpoints to use unified endpoint w/ single unified API key debt: use Etherscan V2 API endpoints to use unified endpoint w/ single unified API key Oct 25, 2024
@zerosnacks zerosnacks changed the title debt: use Etherscan V2 API endpoints to use unified endpoint w/ single unified API key debt: use the single Etherscan V2 API endpoint to unified verification / interaction flow w/ single unified API key Oct 25, 2024
@zerosnacks zerosnacks changed the title debt: use the single Etherscan V2 API endpoint to unified verification / interaction flow w/ single unified API key debt: use the single Etherscan V2 API endpoint to unified verification / query flow w/ single unified API key Oct 25, 2024
@zerosnacks zerosnacks changed the title debt: use the single Etherscan V2 API endpoint to unified verification / query flow w/ single unified API key debt: use the single Etherscan V2 API endpoint for unified verification / query flow w/ single API key Oct 28, 2024
@grandizzy grandizzy added the T-post-V1 Area: to tackle after V1 label Nov 7, 2024
@iainnash
Copy link
Contributor

Has this been started or would taking a first PR pass be helpful?

@zerosnacks
Copy link
Member Author

Hi @iainnash, this is definitely something we will want to do, just outside of the scope of our 1.0 milestone due to scope of the change (I expect we can simplify quite a lot of code and likely make breaking changes). We also have to be mindful that the Etherscan API V2 is still in beta. A first PR pass to explore this would be very useful, even if it is just a draft!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-internals Area: internals A-verification Area: verification T-debt Type: code debt T-feature Type: feature T-post-V1 Area: to tackle after V1
Projects
Status: Todo
Development

No branches or pull requests

4 participants
@iainnash @grandizzy @zerosnacks and others