Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add guide for EIP-712 signatures with vm.sign / vm.addr #159

Closed
gakonst opened this issue Apr 3, 2022 · 4 comments · Fixed by #252
Closed

Add guide for EIP-712 signatures with vm.sign / vm.addr #159

gakonst opened this issue Apr 3, 2022 · 4 comments · Fixed by #252
Assignees
@tbtstl
Labels
A-forge Area: forge A-reference Area: reference good first issue Good for newcomers T-enhancement Type: enhance existing docs

Comments

@gakonst
Copy link
Member

gakonst commented Apr 3, 2022

Explain how EIP712 works and create & verify signatures via the sign & addr cheatcodes https://github.com/Rari-Capital/solmate/blob/7c34ed021cfeeefb1a4bff7e511a25ce8a68806b/src/test/ERC20.t.sol#L89-L103
@onbjerg onbjerg added T-enhancement Type: enhance existing docs good first issue Good for newcomers A-forge Area: forge A-reference Area: reference labels Apr 3, 2022
@onbjerg onbjerg self-assigned this Apr 6, 2022
@tbtstl
Copy link

tbtstl commented Apr 6, 2022

@onbjerg Are you actively working on this? Happy to dig in now if you'd like, we're actively working on this for a ZORA PR

@onbjerg
Copy link
Member

onbjerg commented Apr 7, 2022

@tbtstl Feel free to take it on! I just assigned myself to a bunch of issues I'm going to address soon, but the more the merrier 😄

@onbjerg onbjerg assigned tbtstl and unassigned onbjerg Apr 7, 2022
@onbjerg onbjerg moved this to Todo in Foundry Book Apr 14, 2022
@onbjerg onbjerg moved this to Todo in Foundry Book Apr 14, 2022
@onbjerg
Copy link
Member

onbjerg commented Apr 25, 2022

Hey @tbtstl, just pinging to hear if you're still working on this 😊

@kulkarohan
Copy link
Contributor

hey @onbjerg, yup just making some final changes and i'll push!

@kulkarohan kulkarohan mentioned this issue Apr 29, 2022
Merged
@onbjerg onbjerg moved this from Todo to In Progress in Foundry Book May 5, 2022
Repository owner moved this from Todo to Done in Foundry Book May 27, 2022
Repository owner moved this from In Progress to Done in Foundry Book May 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tbtstl tbtstl

Labels
A-forge Area: forge A-reference Area: reference good first issue Good for newcomers T-enhancement Type: enhance existing docs
Projects
No open projects
Foundry Book
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(docs): EIP-712 Tutorial kulkarohan/book
4 participants
@onbjerg @tbtstl @gakonst @kulkarohan