From 4fb5d0e9341152c9be42c88f10ece146389cf899 Mon Sep 17 00:00:00 2001 From: Andre Detsch Date: Tue, 28 Nov 2023 12:11:13 -0300 Subject: [PATCH] fixup! tuf: Create a new API to encapsulate TUF operations Signed-off-by: Andre Detsch --- src/tuf/akrepo.h | 8 ++++---- src/tuf/localreposource.h | 3 ++- 2 files changed, 6 insertions(+), 5 deletions(-) diff --git a/src/tuf/akrepo.h b/src/tuf/akrepo.h index 792d0f99..40e66824 100644 --- a/src/tuf/akrepo.h +++ b/src/tuf/akrepo.h @@ -11,8 +11,8 @@ namespace aklite::tuf { // TufRepo implementation that uses libaktualizr to provide TUF metadata handling and storage class AkRepo : public TufRepo { public: - AkRepo(const boost::filesystem::path& storage_path); - AkRepo(const Config& config); + explicit AkRepo(const boost::filesystem::path& storage_path); + explicit AkRepo(const Config& config); std::vector GetTargets() override; void updateMeta(std::shared_ptr repo_src) override; void checkMeta() override; @@ -29,10 +29,10 @@ class AkRepo : public TufRepo { public: explicit FetcherWrapper(std::shared_ptr src); void fetchRole(std::string* result, int64_t maxsize, Uptane::RepositoryType repo, const Uptane::Role& role, - Uptane::Version version) const; + Uptane::Version version) const override; void fetchLatestRole(std::string* result, int64_t maxsize, Uptane::RepositoryType repo, - const Uptane::Role& role) const; + const Uptane::Role& role) const override; private: std::shared_ptr repo_src; diff --git a/src/tuf/localreposource.h b/src/tuf/localreposource.h index 6465cb96..140bfd99 100644 --- a/src/tuf/localreposource.h +++ b/src/tuf/localreposource.h @@ -7,7 +7,8 @@ class LocalRepoSource : public RepoSource { public: class NotFoundException : public std::runtime_error { public: - NotFoundException(const std::string &path) : std::runtime_error("Metadata hasn't been found; file path: " + path) {} + explicit NotFoundException(const std::string &path) + : std::runtime_error("Metadata hasn't been found; file path: " + path) {} }; LocalRepoSource(const std::string &name_in, const std::string &local_path);