Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add documentation for configuring flask secret key #424

Open
1 of 3 tasks
alok760 opened this issue Mar 14, 2019 · 6 comments
Open
1 of 3 tasks

Add documentation for configuring flask secret key #424

alok760 opened this issue Mar 14, 2019 · 6 comments

Comments

@alok760
Copy link
Member

alok760 commented Mar 14, 2019

I'm submitting a ... (check one with "x")

  • bug report
  • feature request
  • support request => Please do not submit support requests here, instead ask your query in out Gitter channel at https://gitter.im/fossasia/meilix

Actual Behaviour
There is no documentation for configuring flask secret key.

Expected Behaviour

  • Add documentation for configuring flask secret key using environment variables on Local, Heroku and Docker.

Related code:

meilix-generator/app.py

Lines 25 to 26 in 35a2bb7

# Initializing flask secret key using the environment variable "secret_key"
app.secret_key = os.environ.get('secret_key', 'z528&^FJjhd_t2bxc#$2').encode()

@pranav1698
Copy link

It would be great if this could be hidden

@xeon-zolt
Copy link
Member

the original secrete key is different

@pranav1698
Copy link

Also, I think this would require admin rights from the heroku server but you can test it for your local development

@xeon-zolt
Copy link
Member

i have already changed it

@Patil2099
Copy link

Can I work on this ? If yes can you explain how to add something to documentation.
Also # Initializing flask secret key using the environment variable "secret_key"
app.secret_key = os.environ.get('secret_key', 'z528&^FJjhd_t2bxc#$2').encode()
what is the second argument here? @alok760

@alok760
Copy link
Member Author

alok760 commented Jul 22, 2019

@Patil2099 the second argument is the default value. To change the secret key, you need to set an environment variable secret_key. You already need to set your Travis Key as an env variable, similarly, you need to set the flask secret key.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants