Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nosetests should not be used in travis #116

Open
1 of 3 tasks
ParthS007 opened this issue Jan 25, 2018 · 3 comments
Open
1 of 3 tasks

Nosetests should not be used in travis #116

ParthS007 opened this issue Jan 25, 2018 · 3 comments
Labels
GCI Google Code-in task

Comments

@ParthS007
Copy link
Member

I'm submitting a ... (check one with "x")

  • bug report
  • feature request
  • support request => Please do not submit support requests here, instead ask your query in out Gitter channel at https://gitter.im/fossasia/meilix

Actual Behaviour
Presently, Travis run script nosetests app.py while testing which is not needed as nose is used for testing unit tests and moreover nose collects tests from unittest.TestCase subclasses or we can also write simple test functions, as well as test classes that are not subclasses of unittest.TestCase.
But there are no such tests in app.py so the command nosetests app.py is executed with ok status always irrespective of the changes done in the Pull Request.

Expected Behaviour
We should add tests which test functions present in app.py which will be tested in Travis.

Steps to reproduce it

Please see Travis logs for any PR. Like here
image

Would you like to work on the issue?
Yes

@mariobehling @meets2tarun @xeon-zolt Please give your views

@meets2tarun
Copy link
Member

Thanks @ParthS007
Go for solving the issue.

@tabesin
Copy link
Member

tabesin commented Sep 25, 2018

What is the status of this item?

tabesin added a commit that referenced this issue Sep 28, 2018
@tabesin tabesin added the GCI Google Code-in task label Oct 24, 2018
@pranav1698
Copy link

What tests we need to run for this issue?
We cannot run test for the index function because it requires a live HTTP request and which will make the travis build fail

@ParthS007 ParthS007 removed their assignment Oct 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
GCI Google Code-in task
Projects
None yet
Development

No branches or pull requests

4 participants