Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[colorfont_tables] Fails for any variable font with SVG table #4946

Open
khaledhosny opened this issue Dec 28, 2024 · 1 comment
Open

[colorfont_tables] Fails for any variable font with SVG table #4946

khaledhosny opened this issue Dec 28, 2024 · 1 comment

Comments

@khaledhosny
Copy link
Contributor

Observed behaviour

colorfont_tables will FAIL if a font is both variable and have an SVG table. Even though SVG table indeed does not support font variations, not every glyph in a variable fonts has variations and a font might be a variable font and a color font but the color glyphs have no variations.

Expected behaviour

The check should see if color glyphs included in the SVG table correspond to glyphs with variations in the gvar or CFF2 tables before FAIL’ing such fonts.

Resources and steps needed to reproduce

https://github.com/aliftype/raqq/releases/tag/v2.00 FAIL’s with this check even though the color glyphs have no variations.

@felipesanches
Copy link
Collaborator

felipesanches commented Dec 29, 2024

Earlier today this check was listed as part of Universal profile (because earlier this month I hoped it would be useful for everybody) and it was also listed in the pending_review list of most of the vendor-specific profiles, so it was not in fact active for them until getting reviewed and approved.

@khaledhosny made it clear that this should definitely not be placed in Universal, so at PR #4949 I moved it back to Google Fonts profile.

The description of this issue, though, seems to be valid regardless of the chosen profile, so I'll keep it open.
But would you it be OK if we address this after the v0.13.0 release?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants