Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(a380x/fms): Vapp wind correction #9809

Merged
merged 4 commits into from
Jan 29, 2025

Conversation

Waveif
Copy link
Contributor

@Waveif Waveif commented Jan 28, 2025

Fixes #9333

Summary of Changes

Fixed an issue where vapp was taking the full headwind factor instead of 1/3 of the steady headwind.

Screenshots (if necessary)

Before:
image

After:
image

References

Reference image is linked in the issue #9333

Additional context

Discord username (if different from GitHub):
waveif

Testing instructions

How to download the PR for QA

Every new commit to this PR will cause new A32NX and A380X artifacts to be created, built, and uploaded.

  1. Make sure you are signed in to GitHub
  2. Click on the Checks tab on the PR
  3. On the left side, find and click on the PR Build tab
  4. Click on either flybywire-aircraft-a320-neo, flybywire-aircraft-a380-842 (4K) or flybywire-aircraft-a380-842 (8K) download link at the bottom of the page

@Waveif Waveif changed the title fix(a380x/fms) Vapp wind correction fix(a380x/fms): Vapp wind correction Jan 28, 2025
Copy link
Contributor

@flogross89 flogross89 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch, thanks! To make it more accurate, could you please

  • Always add 5kts for manual A/THR on landing technique (which is what we should assume for now), and
  • Remove the minimum wind component of 5 kts from addWindComponent?

Seems to be slightly different from the A320, where the wind correction is between 5 and 15 kts. On the A380 with A/THR on and 45kts headwind, it seems it can be VLS+20 (if I interpret my references correctly)

@flogross89 flogross89 added FMS QA A380 Only QA only for A380 required A380X Related to the A380X aircraft labels Jan 28, 2025
@flogross89 flogross89 added this to the v0.13.0 milestone Jan 28, 2025
Copy link
Contributor

@flogross89 flogross89 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Update: Sorry for the confusion, I looked in the OIT calculations instead of the flight envelope part. Your implementation is correct, I'll approve it. Since it's such a small change, we don't need QA.

@flogross89 flogross89 added QA Not Required and removed QA A380 Only QA only for A380 required labels Jan 28, 2025
@flogross89
Copy link
Contributor

@Waveif Before merging, could you please add a changelog entry?

@Waveif
Copy link
Contributor Author

Waveif commented Jan 29, 2025

Sure thing

@flogross89
Copy link
Contributor

Sure thing

Thanks! Merging now.

@flogross89 flogross89 merged commit fade1a5 into flybywiresim:master Jan 29, 2025
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A380X Related to the A380X aircraft FMS QA Not Required
Projects
Status: ✔️ Done
Development

Successfully merging this pull request may close these issues.

[A380X/FMS] Incorrect wind correction calculation for approach speeds
2 participants