Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nested Navigation #3

Open
juliusspencer opened this issue Mar 21, 2019 · 6 comments
Open

Nested Navigation #3

juliusspencer opened this issue Mar 21, 2019 · 6 comments
Labels
question Further information is requested

Comments

@juliusspencer
Copy link

Hi,

I'd like to be able to use flutter_redux_navigation with Nested Navigation.

The Navigator class documentation under Nesting Navigators describes this:
https://docs.flutter.io/flutter/widgets/Navigator-class.html

This would help with tabbed navigation where each tab has its own Navigator.

Thank you!

@esarbanis
Copy link
Collaborator

I will have to do some testing and get back to you on that.

@esarbanis esarbanis added the question Further information is requested label Mar 21, 2019
@esarbanis
Copy link
Collaborator

@juliusspencer it does not support nested Navigators currently, but I do see a way around it.

How about having an isNested flag in NavigateToAction that will require to assign a NavigatorHolder.nestedNavigatorKey to the nested Navigator.

WDYT?

@juliusspencer
Copy link
Author

That sounds good @esarbanis. Thank you for taking the time to look into this.

@esarbanis
Copy link
Collaborator

@juliusspencer I think I under-estimated the level of involvement this feature has. Although I managed to get it working there is a very tricky part to it, which has to do with navigating using explicitly one of the nested navigators.

I don't want to rush this so that we can get it right. Any thoughts would be more than welcome.

@juliusspencer
Copy link
Author

No problem. Thanks for taking the time. I'm not familiar enough with it to make any good recommendations unfortunately.

@simkepal
Copy link

Hey guys! Was this ever solved?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
question Further information is requested
Projects
None yet
Development

No branches or pull requests

3 participants