Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG] Not all futures are awaited so impossible to create a dart custom dart script #550

Open
vanlooverenkoen opened this issue Mar 14, 2024 · 1 comment · May be fixed by #551
Open

[BUG] Not all futures are awaited so impossible to create a dart custom dart script #550

vanlooverenkoen opened this issue Mar 14, 2024 · 1 comment · May be fixed by #551

Comments

@vanlooverenkoen
Copy link

ℹ️ Info

Version: 0.13.1

💬 Description

We are creating a dart script that just configures everything in dart. I found that not all futures are awaited resulting in a bug in my script.

📜 Pubspec.yaml

No other dependencies
@vanlooverenkoen
Copy link
Author

On top of that,

.then & await is used throughout the package in different ways.

Also writing files is sometimes done with .then & something it is done with the sync method.

vanlooverenkoen added a commit to impaktfull/flutter_launcher_icons that referenced this issue Mar 14, 2024
@vanlooverenkoen
fix fluttercommunity#550 and inconstant implementation of reading & w…
91bd321 
…riting files.
@vanlooverenkoen vanlooverenkoen linked a pull request Mar 14, 2024 that will close this issue
Open
mwhobrey added a commit to mwhobrey/flutter_launcher_icons that referenced this issue Aug 21, 2024
@mwhobrey
Merge remote-tracking branch 'Impaktfull/fix/fluttercommunity#550-una…
d8b21bf 
…waited-futures'
mwhobrey pushed a commit to mwhobrey/flutter_launcher_icons that referenced this issue Aug 22, 2024
@vanlooverenkoen @mwhobrey
fix fluttercommunity#550 and inconstant implementation of reading & w…
a252ba8 
…riting files.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix #550 inconstant implementation of reading & writing files. impaktfull/flutter_launcher_icons
1 participant
@vanlooverenkoen