Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Browser action icon is hard to see when there is a dark background #19

Open
jobara opened this issue Sep 1, 2020 · 4 comments
Open
Labels
bug Something isn't working
Milestone

Comments

@jobara
Copy link
Member

jobara commented Sep 1, 2020

Describe the bug

The browser action icon, which is used to open the UIO+ panel, is currently a dark blue gear. This displays okay on the default Chrome theme, but is hard to see when run in incognito mode (black background) or other custom themes.

See: https://developer.chrome.com/extensions/browserAction for tips.

Originally filed as GPII-2841

To reproduce

Steps to reproduce the behavior:

  1. Install and enable UIO+
    Notice that the browser action icon, blue gears, are small and may be hard to see.

gear icon on incognito backgroung

Expected behavior

Browser action icon should be easily perceived on all backgrounds.

@jobara jobara added the bug Something isn't working label Sep 1, 2020
@jobara
Copy link
Member Author

jobara commented Sep 1, 2020

One option would be to use the UIO+ icon as the browser action as well. It displays the graphic on a white background and will likely appear better with various themes applied to the browser.

UIO+ icon

@jobara
Copy link
Member Author

jobara commented Sep 1, 2020

For incognito mode, could try to detect if in incognito mode and update the browser action if so (see: https://stackoverflow.com/questions/36931484/light-dark-browseraction-icons-in-chrome-51 ).

For dark mode could try to use the window.matchMedia with "(prefers-color-scheme: dark)" to check if in dark mode.
See: https://developer.chrome.com/extensions/browserAction#method-setIcon for how to programatically set the browser action icon

@jobara
Copy link
Member Author

jobara commented Sep 1, 2020

Suggestion from the morphic team was to put it on a white background, they had to do something similar for the morphic icon to show up on a computer's desktop.

@jobara
Copy link
Member Author

jobara commented Sep 1, 2020

Design Crit notes

@jobara jobara added this to the v1.0.0 milestone Sep 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant