Window object not being recycled after ribbon window is closed

[leixao]

Hi, I'm having a very strange problem using this library, possibly a memory leak?
In my application, I need to create multiple ribbon windows, which contain some ribbon buttons and commands.
Defined as follows:

I need to create a lot of windows like this and when they are closed, in VS memory monitoring tool I found that the window object is not being recycled. After reading the source code and doing some tests, I found that there are three situations in which the window can be recycled.

1. Do not set commands for ribbon buttons;
2. In the window closed event, set the command to null;
3. Remove the IconPresenter from the button template.
   
   I didn't find the relation between IconPresenter and Command from the code.

Here is my test project:
Ribbon.MemLeakTest-main.zip

---

Environment

• Fluent.Ribbon v9.0.1
• Windows 11
• .NET Core 3.1

[batzen]

This was caused by wrong code in the IconPresenter which caused all IconPresenters, that got disabled at least once, to be held in memory by the GrayscaleEffect that's being used in IconPresenter.

[batzen]

Thanks for investigating and providing a repro.

[leixao]

Hi, I updated the version in the test project to 9.0.4, the memory leak problem still exists, the bug does not seem to be fixed.

[batzen]

I can't reproduce your issue with Fluent.Ribbon 9.0.4.
Did you change anything in your sample application?

[leixao]

Aha probably because VS didn't recompile
Problem solved :)
9.0.4 works fine