Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Controls might not be shown when using default layout of RibbonToolbar #925

Closed
nishy2000 opened this issue May 4, 2021 · 0 comments · Fixed by #926
Closed

Controls might not be shown when using default layout of RibbonToolbar #925

nishy2000 opened this issue May 4, 2021 · 0 comments · Fixed by #926
Labels
Bug 🐞
Milestone
9.0

Comments

@nishy2000
Copy link
Contributor

Internal controls not may be shown when using default layout of RibbonToolbar.

How to reproduce this issue:

  1. Add the following code before the <Fluent:RibbonGroupBox Header="Group"> line in TestContent.xaml.
                <Fluent:RibbonGroupBox Header="WrapPanelLayuot">
                    <Fluent:RibbonToolBar>
                        <Fluent:Button Header="Green"
                                       SizeDefinition="Middle,Middle,Small"
                                       Icon="pack://application:,,,/Fluent.Ribbon.Showcase;component/Images/Green.png"
                                       LargeIcon="pack://application:,,,/Fluent.Ribbon.Showcase;component/Images/GreenLarge.png" />
                        <Fluent:Button Header="Gray"
                                       SizeDefinition="Middle,Middle,Small"
                                       Icon="pack://application:,,,/Fluent.Ribbon.Showcase;component/Images/Gray.png"
                                       LargeIcon="pack://application:,,,/Fluent.Ribbon.Showcase;component/Images/GrayLarge.png" />
                    </Fluent:RibbonToolBar>
                </Fluent:RibbonGroupBox>
  1. Start Fulent.Ribbon.Showcase
  2. Buttons in WrapPanelLayuot RibbonGroupBox are not shown.

Environment

  • Fluent.Ribbon 9.0.0 preview (latest develop branch (fe50413 [fe50413]))
  • Windows 10 Pro 20H2
  • .NET Framework 4.6.2 / net5.0-windows
nishy2000 added a commit to nishy2000/Fluent.Ribbon that referenced this issue May 4, 2021
@nishy2000
fix: Modify measured height (fix fluentribbon#925)
67efe74
@nishy2000 nishy2000 mentioned this issue May 4, 2021
Merged
@batzen batzen changed the title Internal controls not may be shown when using default layout of RibbonToolbar Controls may not be shown when using default layout of RibbonToolbar May 4, 2021
@batzen batzen changed the title Controls may not be shown when using default layout of RibbonToolbar Controls might not be shown when using default layout of RibbonToolbar May 4, 2021
batzen added a commit that referenced this issue May 4, 2021
@batzen
Merge pull request #926 from nishy2000/hotfix-925-RibbonToolBar-layout
0bd5942 
Fix for #925 (RibbonToolBar layout issue)
batzen added a commit that referenced this issue May 4, 2021
@batzen
Adding #925 to changelog
77202b2
batzen added a commit that referenced this issue May 4, 2021
@batzen
Adding missing attribution for #925 to changelog
69f4464
@batzen batzen added the Bug 🐞 label May 5, 2021
@batzen batzen added this to the 9.0 milestone May 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Bug 🐞
Projects
None yet
Milestone
9.0
Development

Successfully merging a pull request may close this issue.

Fix for #925 (RibbonToolBar layout issue) nishy2000/Fluent.Ribbon
2 participants
@batzen @nishy2000