-
-
Notifications
You must be signed in to change notification settings - Fork 517
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature simplified ribbon #924
Feature simplified ribbon #924
Conversation
- Add a read-only IsSimplified property to child controls of the ribbon control - Propagate the IsSimplified value of the ribbon control to the child controls
- Add control template for simplified mode to child controls of the RibbonGroupBox control
- add SimplifiedSizeDefinition property for simplified mode to child controls of the RibbonGroupBox control
- change the retrieving method of RibbonGroupBox's child controls from Items to ItemContainerGenerator - refactor some controls (RibbonProperties/Ribbon/RibbonTabItem/DropDwonButton/SplitButton)
- fix the visual size of the ribbon controls might be incorrect when switching between ribbon tabs
Display the items in the pop-up panel vertically when RibbonGroupBox is in the collapsed state
- reflect IsSimplified property to chiled controls in RibbontoolBar control - reflect IsSimplified property to chiled controls in RibbonGroupBox control
…on.Templates.xxx.Simplified format.
…s Small or Middle
…-simplified-ribbon
- The default value of StateDefinition is "Large,Middle,Small,Collapsed", but the default value of SimplifiedStateDefinition is "Large,Middle,Collapsed"
@nishy2000 I added a new |
@nishy2000 Are you still working on this or should i start reviewing your changes? |
@batzen |
@nishy2000 Of course. Didn't want to pressure you. Take your time and just ping me if you are ready. |
@nishy2000 It might be, but...I'd recommend thinking twice before assuming that both GUIs are adequately-suited to every use-case. |
@Splitwirez |
@batzen |
@nishy2000 Will try to have a look during the weekend. |
@nishy2000 I started my review during the weekend but didn't have time to finish it. Will try to get it done during the week. Sorry for the delay. |
Sorry again for the delay. There are a couple of things i don't really like. The other part are the separate templates. Which were the reasons to create separate templates for all the other controls? And thanks for all your great work and your patience. |
… differences in ComboBox template definitions.
@batzen About iconImageBorder: About separate templates: Overall I separated the templates for a several reasons.
The first is to avoid affecting the existing behavior (classic ribbon). I wanted to avoid adding functionality to the Simple Ribbon that would affect the Classic Ribbon's functionality. The second is to avoid conflicts. During the implementation of the Simple Ribbon, bug fixes and feature improvements to Fluent.Ribbon continued. If a single template is used to deal with the problem, it is difficult to understand the differences when merging, and conflicts are more likely to occur. Third, the complexity of triggers is increasing. If we use a single template, IsSimplified will be added to the trigger condition, making it a multi-condition instead of a single condition. I thought this might be a complication. However, if you think the above reason is not a big deal, I can integrate the template. In fact, for example, I was concerned about the existence of duplicate code in the ComboBox template, since the definition of the Popup control is exactly the same. Therefore, I thought of a countermeasure. However, I couldn't even change the Popup definition to a style definition because it is referenced in Template.Triggers. |
I have to admit that the triggers are really a mess already and sometimes way too complex. What do you think about this suggestion: And i should introduce something like XAML-Styler to have all XAML formatted in the same way. That way comparing everything should get a lot easier. That should be the first thing for me to do after your PR is merged. @nishy2000 Just tell me when i can merge. And sorry again for the long delay. |
… differences in some control template definitions.
@batzen |
I will resolve the conflicts tomorrow and merge. |
I am proceeding with implementation based on PR #707 for issue #695.
This implement resolves #695 (a part of full feature)
Note: In the showcase program, the Simplified Ribbon can be found under Tests --> Windows --> "Open Simplified Ribbon-Window"
First of all, I am currently implementing the following items.
Overflow button is not supported in this PR. I will create another PR to support the overflow button.
The basic idea on Simplified mode is that the child controls of the RibbonGroupBox show the elements as follows: