Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CheckBox.Header - InvalidCastException #704

Closed
atlastodor opened this issue Mar 6, 2019 · 6 comments
Closed

CheckBox.Header - InvalidCastException #704

atlastodor opened this issue Mar 6, 2019 · 6 comments
Assignees
Labels
Milestone

Comments

@atlastodor
Copy link

Invalid cast exception in Fluent.CheckBox.Header (https://github.com/fluentribbon/Fluent.Ribbon/blob/develop/Fluent.Ribbon/Controls/CheckBox.cs line 74).

Why does it cast to string, when both the DP and the Property are both of type Object? The issue is apparent after the new automation peer improvement.

PS: If you fix it, is it possible to create a new NuGet with the fix? We'd love to update from the ancient Alpha we are currently running.

Environment

  • Fluent.Ribbon __v7.0.0__alpha0623
  • Windows 10
  • .NET Framework 4.7
@atlastodor
Copy link
Author

Forgot to mention, we have a StackPanel for the Header property.

@batzen
Copy link
Member

batzen commented Mar 6, 2019

Uh. Forgot to remove that cast when i changed the type. Will fix it and release a new preview in about seven hours.

@atlastodor
Copy link
Author

The same bug is found in those classes as well: Checkbox, ComboBox, RadioButton, RibbonControl and ToggleButton. Could you fix them too. Danke dir!

@batzen
Copy link
Member

batzen commented Mar 6, 2019

Damn. Thanks for pointing those out.
Will have a look at how i can prevent such mistakes by using an analyzer in the future.

@batzen batzen added this to the 7.0.0 milestone Mar 6, 2019
@batzen batzen self-assigned this Mar 6, 2019
@batzen batzen added the Bug 🐞 label Mar 6, 2019
@batzen batzen closed this as completed in 59d2ccd Mar 6, 2019
@batzen
Copy link
Member

batzen commented Mar 6, 2019

Package is uploaded. You'll just have to wait for the nuget indexing to finish https://www.nuget.org/packages/Fluent.Ribbon/7.0.0-alpha0624

@batzen
Copy link
Member

batzen commented Mar 6, 2019

@atlastodor FYI

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants