Fix Ribbon.OnTitleBarChanged clearing the new title bar instead of the old one #450
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…g the title bar properties. RemoveQuickAccessToolBarFromTitleBar and MoveQuickAccessToolBarToTitleBar now require a reference to the TitleBar instance to be passed in.
… instead of expecting the template to provide one.
|
Thanks for contributing! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed Ribbon.OnTitleBarChanged not using the 'old value' when clearing the title bar properties (a null reference exception was being thrown when the new value is null).
For this to work the RemoveQuickAccessToolBarFromTitleBar and MoveQuickAccessToolBarToTitleBar methods now have a parameter to specify the RibbonTitleBar instance to act on.