Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

InRibbonGallery when loaded, mouse wheel up or down cause crash. #405

Closed
Yumeryu opened this issue Mar 10, 2017 · 2 comments
Closed

InRibbonGallery when loaded, mouse wheel up or down cause crash. #405

Yumeryu opened this issue Mar 10, 2017 · 2 comments
Assignees
Labels
Milestone

Comments

@Yumeryu
Copy link

Yumeryu commented Mar 10, 2017

I have a InRibbonGallery with a lot of data inside, when loaded, before clicking any up, down or expand button, using mouse wheel up or down cause crash, with error index out of range.


Environment

  • Fluent.Ribbon _v5.0.0_dev0477
  • Theme generic (not needed in version 5.0 and upwards)
  • Windows 10
  • .NET Framework 4.5.2
@batzen
Copy link
Member

batzen commented Mar 10, 2017

Some details would be nice.
Including a StackTrace, amount of data and property values on the InRibbonGallery.
The best would probably be a repro.

@batzen batzen self-assigned this Mar 10, 2017
@Yumeryu
Copy link
Author

Yumeryu commented Mar 13, 2017

I do apologize, a bit of quick trigger there.

I actually did spend a bit more time on it. Switch off "Only My Code". And I found the issue.

In file RibbonTabControl.cs

From Line 563:
if (selectedIndex < visualItems.Count - 1)
{
visualItems[selectedIndex].IsSelected = false;
selectedIndex++;
visualItems[selectedIndex].IsSelected = true;
}

I believe that should be:
if (selectedIndex >= 0 && selectedIndex < visualItems.Count - 1)
{
visualItems[selectedIndex].IsSelected = false;
selectedIndex++;
visualItems[selectedIndex].IsSelected = true;
}

@batzen batzen added this to the 6.0.0 milestone Mar 14, 2017
@batzen batzen closed this as completed in 896be0b Mar 14, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants