Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add start screen like in office 2013 and upwards #242

Closed
batzen opened this issue Jan 10, 2016 · 10 comments
Closed

Add start screen like in office 2013 and upwards #242

batzen opened this issue Jan 10, 2016 · 10 comments
Assignees
Milestone

Comments

@batzen
Copy link
Member

batzen commented Jan 10, 2016

As suggested in PR (#227) from @maurosampietro a start screen like in office 2013 and upwards should be implemented.

@batzen batzen self-assigned this Jan 10, 2016
@batzen batzen added this to the 4.0.0 milestone Jan 10, 2016
This was referenced Jan 10, 2016
batzen added a commit that referenced this issue Jan 10, 2016
@batzen
Copy link
Member Author

batzen commented Jan 10, 2016

@maurosampietro could you have a look and see if I didn't miss something?

@maurosampietro
Copy link
Contributor

Hi, i had a quick look this morning.
Everything is ok, works with and without dwm and WindowSteeringHelpeControl
solves titlebar issues in the left panel.

Although Office 2013 theme is perfect with and without dwm, it looks pretty
bad when using other themes.

I dont know how the StartScreen should look like with themes different than
Office 2013 since it did not exist before that version, but when switching
to Office 2010 or Windows 8 themes immediately note the following:

If "don't use dwm" is unchecked:

If "don't use dwm" is checked:

  • Left panel's top border is ok.
  • Left panel should have the same color/brush as the titlebar and window
    borders; this is particularly noticeable with Blue and Silver themes. You
    can have a look to black theme to have an idea of how it should look, even
    though Black theme is not using the exactly same color/brush either.

I noticed you preferred to deal with a single generic style.
Maybe I should have pointed out i chose to make different styles per
theme instead of a generic one exactly to solve this issues separately in a
later moment.

Mauro Sampietro

@batzen
Copy link
Member Author

batzen commented Jan 10, 2016

The image is missing in your response.

As for the generic style:
I just hate it to have to duplicate the whole template, and maintain all of them, just because there has to be one line with different values.

I will try to avoid duplicated templates from now on for everything and instead introduce new properties to the control where needed and differentiate by style settings.

As a side note, the generic solution has exactly the same color you chose.

The borders behave the same as the backstage in those themes, regarding the left border. It true that it stretches to the top border of the window, but that's how the start screen behaves in Office 2013 and upwards.

If anyone really uses the start screen with the office 2010 or windows 8 theme and complains about the border behavior/look I might think about a change, but not yet. ;-)

@maurosampietro
Copy link
Contributor

I will try to fix those minor styling issues without template duplicates even though having different templates seemed the way to go in this particular case.

Can you please provide a name of a control that already deals with style with properties as you described, just so i can use it as example?

Thank you!

Mauro Sampietro
Inviato da iPhone

Il giorno 10 gen 2016, alle ore 23:21, Bastian Schmidt [email protected] ha scritto:

The image is missing in your response.

As for the generic style:
I just hate it to have to duplicate the whole template, and maintain all of them, just because there has to be one line with different values.

I will try to avoid duplicated templates from now on for everything and instead introduce new properties to the control where needed and differentiate by style settings.

As a side note, the generic solution has exactly the same color you chose.

The borders behave the same as the backstage in those themes, regarding the left border. It true that it stretches to the top border of the window, but that's how the start screen behaves in Office 2013 and upwards.

If anyone really uses the start screen with the office 2010 or windows 8 theme and complains about the border behavior/look I might think about a change, but not yet. ;-)


Reply to this email directly or view it on GitHub.

@batzen
Copy link
Member Author

batzen commented Jan 11, 2016

Even though the BackstageTabControl uses different templates it also has properties dedicated for styling. For example ItemsPanelBackground.

Which styling issues are you planning to fix?

@maurosampietro
Copy link
Contributor

Dwm disabled in Office 2010 theme issues i described previously

Mauro Sampietro
Inviato da iPhone

Il giorno 11 gen 2016, alle ore 13:56, Bastian Schmidt [email protected] ha scritto:

Even though the BackstageTabControl uses different templates it also has properties dedicated for styling. For example ItemsPanelBackground.

Which styling issues are you planning to fix?


Reply to this email directly or view it on GitHub.

@batzen
Copy link
Member Author

batzen commented Jan 11, 2016

Ah, now I got it.
If you haven't already started i could give it a try.

@batzen
Copy link
Member Author

batzen commented Jan 11, 2016

Just had a look. Fixing that one will be a bit more difficult as it depends on properties only available on the window itself...

@batzen
Copy link
Member Author

batzen commented Feb 3, 2016

So from my point of view this looks kinda finished.
Anything you think that still has to be done?

@maurosampietro
Copy link
Contributor

We can close. Well done!

Mauro Sampietro
Inviato da iPhone

Il giorno 03 feb 2016, alle ore 22:21, Bastian Schmidt [email protected] ha scritto:

So from my point of view this looks kinda finished.
Anything you think that still has to be done?


Reply to this email directly or view it on GitHub.

@batzen batzen closed this as completed Feb 6, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants