-
-
Notifications
You must be signed in to change notification settings - Fork 517
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add start screen like in office 2013 and upwards #242
Comments
@maurosampietro could you have a look and see if I didn't miss something? |
Hi, i had a quick look this morning. Although Office 2013 theme is perfect with and without dwm, it looks pretty I dont know how the StartScreen should look like with themes different than If "don't use dwm" is unchecked:
If "don't use dwm" is checked:
I noticed you preferred to deal with a single generic style. Mauro Sampietro |
The image is missing in your response. As for the generic style: I will try to avoid duplicated templates from now on for everything and instead introduce new properties to the control where needed and differentiate by style settings. As a side note, the generic solution has exactly the same color you chose. The borders behave the same as the backstage in those themes, regarding the left border. It true that it stretches to the top border of the window, but that's how the start screen behaves in Office 2013 and upwards. If anyone really uses the start screen with the office 2010 or windows 8 theme and complains about the border behavior/look I might think about a change, but not yet. ;-) |
I will try to fix those minor styling issues without template duplicates even though having different templates seemed the way to go in this particular case. Can you please provide a name of a control that already deals with style with properties as you described, just so i can use it as example? Thank you! Mauro Sampietro
|
Even though the BackstageTabControl uses different templates it also has properties dedicated for styling. For example ItemsPanelBackground. Which styling issues are you planning to fix? |
Dwm disabled in Office 2010 theme issues i described previously Mauro Sampietro
|
Ah, now I got it. |
Just had a look. Fixing that one will be a bit more difficult as it depends on properties only available on the window itself... |
So from my point of view this looks kinda finished. |
We can close. Well done! Mauro Sampietro
|
As suggested in PR (#227) from @maurosampietro a start screen like in office 2013 and upwards should be implemented.
The text was updated successfully, but these errors were encountered: