Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ScreenTip is not DPI aware #1165

Closed
yordans opened this issue Sep 1, 2023 · 6 comments
Closed

ScreenTip is not DPI aware #1165

yordans opened this issue Sep 1, 2023 · 6 comments
Assignees
Labels
Milestone

Comments

@yordans
Copy link

yordans commented Sep 1, 2023

Ribbon-aligned ScreenTips are not positioned under the ribbon on DPIs different from 100%, e.g. on 125% DPI the ScreenTip is displayed inside the ribbon.

Environment

  • Fluent.Ribbon 10.0.0
  • Windows 10
  • .NET Framework 4.8
@batzen batzen self-assigned this Sep 2, 2023
@batzen batzen added the Bug 🐞 label Sep 2, 2023
@batzen batzen added this to the 10.0.4 milestone Sep 4, 2023
@batzen batzen closed this as completed in 3f5df94 Sep 8, 2023
@yordans
Copy link
Author

yordans commented Sep 18, 2023

Hello, when 10.0.4 is planned to be released?

@batzen
Copy link
Member

batzen commented Sep 19, 2023

Next weekend.

@batzen
Copy link
Member

batzen commented Sep 20, 2023

@yordans Just released it.

@yordans
Copy link
Author

yordans commented Sep 21, 2023

@batzen Thank you for letting me know.

@yordans
Copy link
Author

yordans commented Oct 17, 2023

Hello, @batzen. I think there is a problem with the fix - the CustomPopupPlacementMethod's arguments are dpi aware and should not be multiplied by the dpiScale. More specifically - popupSize.Height is used when calculating tool tip's above position and should not be multiplied by the dpiScale.

@batzen
Copy link
Member

batzen commented Oct 17, 2023

You are totally right.
I shouldn't have scaled the popup height.

@batzen batzen reopened this Oct 17, 2023
@batzen batzen modified the milestones: 10.0.4, 10.0.5 Oct 17, 2023
batzen added a commit that referenced this issue Oct 19, 2023
@batzen batzen closed this as completed in eb717e0 Oct 19, 2023
batzen added a commit that referenced this issue Oct 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants