Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ComboBox Popup MinWidth too large #1151

Closed
matteoaldera opened this issue Jul 20, 2023 · 6 comments
Closed

ComboBox Popup MinWidth too large #1151

matteoaldera opened this issue Jul 20, 2023 · 6 comments
Assignees
Milestone

Comments

@matteoaldera
Copy link

Upgrading from v9.0.4 to v10.0.0 the property InputWidth is missing from Fluent.Spinner and Fluent.ComboBox.
XLS0413 The property 'InputWidth' was not found in type 'Spinner'
XLS0413 The property 'InputWidth' was not found in type 'ComboBox'

I don't see anything about this break change in the changelog. I've missing somethings?

Thansk a lot!


Environment

  • Fluent.Ribbon v10.0.0
  • Windows 10
  • .NET 6__
@batzen
Copy link
Member

batzen commented Jul 20, 2023

Uh, i guess I forgot to mention that in the changelog.

The instance property was converted to an attached property InputControlProperties.InputWidth.

@matteoaldera
Copy link
Author

Thanks! I've fixed my code but there is a problem...

This is what i get with v9.0.4
9 0 4

And this with v10.0.0
10 0 0
Rewriting the value in debug to fire a hot reload fix this issue.

@batzen
Copy link
Member

batzen commented Jul 22, 2023

That looks strange.
Could you provide a repro for that?

@batzen batzen added the Waiting for user response 😕 Waiting for the reporter to respond to questions made by maintainer. label Jul 23, 2023
@matteoaldera
Copy link
Author

What informations do you need?

@batzen
Copy link
Member

batzen commented Jul 25, 2023

The XAML code you used for the problematic ribbon button in your screenshot or a small project containing everything needed to reproduce the issue.

@batzen batzen removed the Waiting for user response 😕 Waiting for the reporter to respond to questions made by maintainer. label Jul 25, 2023
@matteoaldera
Copy link
Author

This is the code of my RibbonTabItem. I omitted some groupboxes but mentioned them because they are used in ReduceOrder.

<fluent:RibbonTabItem Header="{DynamicResource Lang.Ribbon.Home}" Name="homeRibbon" ReduceOrder="GroupBox1,GroupBox1,GroupBox1,
                             GroupBox2,GroupBox2,GroupBox2,
                             GroupBox3,GroupBox3,GroupBox3,
                             GroupBox4,GroupBox4,GroupBox4,
                             Miscellaneous,Miscellaneous,Miscellaneous">
   <fluent:RibbonGroupBox Name="Miscellaneous" Header="{DynamicResource Lang.Miscellaneous}" IsLauncherVisible="True" LauncherCommand="{Binding ShowMiscellaneousPanelCommand}">
      <!-- GroupBox1-->
      <!-- GroupBox2-->
      <!-- GroupBox3-->
      <!-- GroupBox4-->
      <!-- Miscellaneous -->
      <fluent:RibbonGroupBox Name="Miscellaneous" Header="{DynamicResource Lang.Miscellaneous}" IsLauncherVisible="True" LauncherCommand="{Binding ShowMiscellaneousPanelCommand}">
         <fluent:ComboBox fluent:InputControlProperties.InputWidth="110" Header="{DynamicResource Lang.Purge}" ItemsSource="{Binding VM.PurgeMode}" SelectedItem="{Binding VM.PurgeMode}" IsEditable="False" ItemTemplate="{StaticResource TranslatedEnumComboBox}" SizeDefinition="Large"/>
         <fluent:ComboBox fluent:InputControlProperties.InputWidth="110" IsEditable="false" Header="{DynamicResource Lang.Speed}" ItemsSource="{Binding VM.PrinterSpeeds}" SelectedItem="{Binding VM.PrinterSpeed}" ItemTemplate="{StaticResource TranslatedEnumComboBox}" SizeDefinition="Large" />
   </fluent:RibbonGroupBox>
</fluent:RibbonTabItem>

@batzen batzen changed the title InputWidth ComboBox Popup MinWidth too large Jul 25, 2023
@batzen batzen closed this as completed in 41ea15b Jul 25, 2023
@batzen batzen added this to the 10.0.1 milestone Jul 25, 2023
@batzen batzen self-assigned this Jul 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants