Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Maximising a ribbon window with DWM enabled results in it not maximising properly #10

Closed
redwyre opened this issue Nov 5, 2014 · 16 comments

Comments

@redwyre
Copy link

redwyre commented Nov 5, 2014

You can see the top window border.

This has been happening since upgrading to 3.0.0, 3.0.3 samples still have the issue
ribbon

@ghost
Copy link

ghost commented Nov 7, 2014

I second this. Left is an explorer window, right is my test app.

maxnotmax

@batzen
Copy link
Member

batzen commented Nov 10, 2014

Windows seems to be Windows 7.
Which .NET version are you using?

@ghost
Copy link

ghost commented Nov 10, 2014

I've tried to build it with 4.5 version. Haven't tried older versions though, but unfortunately for me it is not an option now, as app itself (not that test one, but real application I'm developing now) is using features from 4.5.

@batzen
Copy link
Member

batzen commented Nov 11, 2014

I don't understand your answer.
But i will try to have a look at this next weekend.

@ghost
Copy link

ghost commented Nov 11, 2014

I'm using .NET 4.5.
I did not tried to use older versions of .NET.
In my case using of .NET below version 4.5 is not possible anyway.

@batzen batzen modified the milestone: 3.1.0 Nov 16, 2014
@batzen
Copy link
Member

batzen commented Nov 21, 2014

Have to delay investigating and fixing this past version 3.1 as I don't have access to Windows 7 with aero (does not work with hyper-v).

@batzen batzen removed this from the 3.1.0 milestone Nov 21, 2014
@batzen
Copy link
Member

batzen commented Dec 3, 2014

I was finally able to reproduce the issue at work, using Windows 7.
The problem is, I have no clue why this happens. But I guess it's somehow connected to the fact that the WindowChrome is rendered with a corner radius, even when maximized, on Windows 7.
I will see if I can find a way to fix this, but it's not very high priority for me.

@batzen
Copy link
Member

batzen commented Dec 11, 2014

I would be very happy if anyone could have a look at this issue. I don't really get what's causing this...

@ghost
Copy link

ghost commented Dec 21, 2014

Hi. I'm not an expert in what happens deep inside there, but maybe the following fact may help in some way. In .NET 4.5 Microsoft has made some changes so that even their own WPF Ribbon implementation started to have a problems that looks alike. It happens on Vista and 7 too.
http://stackoverflow.com/questions/12567455/wpf-ribbonwindow-ribbon-title-outside-screen
https://connect.microsoft.com/VisualStudio/feedback/details/775972/wpf-ribbon-window-the-border-is-too-thin
Maybe it is not a bug of FluentRibbon at all. But MS doesn't show any haste to fix it. I hope at least you may be able to implement some workaround.

@batzen
Copy link
Member

batzen commented Dec 22, 2014

It's definitely a bug in the WindowChrome class from Microsoft, as we are relying completely on that class to render the window chrome. The class has many bugs and I implemented workarounds for most of them. But this bug, as it seems now, can't be worked around in any way I could come up with. Just have a look at the WindowSizing class were most of the bugs are worked around.

@batzen batzen added the Waiting for user response 😕 Waiting for the reporter to respond to questions made by maintainer. label Mar 27, 2015
@redwyre
Copy link
Author

redwyre commented Mar 30, 2015

I'll see if I can have a look into this

@batzen batzen added WindowChrome and removed Waiting for user response 😕 Waiting for the reporter to respond to questions made by maintainer. labels Apr 7, 2015
@batzen
Copy link
Member

batzen commented Apr 16, 2015

I don't know how to fix the current issues, including this one, related to the microsoft WindowChrome class. Any suggestions from anyone?

@redwyre
Copy link
Author

redwyre commented Apr 25, 2015

Is the only real solution to re-implement WindowChrome?

@batzen
Copy link
Member

batzen commented Aug 25, 2015

I got no time to re-implement it...
Any other suggestions?

@batzen
Copy link
Member

batzen commented Dec 15, 2015

Could anyone have a look if it's fixed in version 4.0 (develop branch)?
I don't have a windows 7 machine at hand.

@batzen
Copy link
Member

batzen commented Jan 10, 2016

Tested this myself and as far as I can tell everything works as it should now.

@batzen batzen closed this as completed Jan 10, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants